MartijnVisser opened a new pull request, #29348:
URL: https://github.com/apache/flink/pull/29348

   ## What is the purpose of the change
   
   * Make release-1.20 compile on Java 8 again
   
   f8b86430c4d, the release-1.20 commit of FLINK-40705, uses `Map.of` in 
`ArrowReaderWriterTest`. Java 8 has no `Map.of`, so every JDK 8 build of 
release-1.20 fails to compile the `flink-python` tests, as in the [last 
nightly](https://github.com/apache/flink/actions/runs/36804869542/job/110186858129)
 (`Java 8 / Compile`).
   
   ## Brief change log
   
   * Replace the two `Map.of` calls in `testMapsAcrossBatches` with a 
`LinkedHashMap` and `Collections.singletonMap`
   
   ## Verifying this change
   
   On JDK 8:
   
   * f8b86430c4d: `flink-python` test compilation fails with the same two 
`cannot find symbol` errors as CI
   * this branch: all 3 `ArrowReaderWriterTest` tests pass
   * this branch with `MapWriter` reverted to before FLINK-40705: both 
`testMapsAcrossBatches` cases fail, so the test still covers the fix
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Claude Opus 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to