MartijnVisser commented on code in PR #29386:
URL: https://github.com/apache/flink/pull/29386#discussion_r4187136146
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java:
##########
@@ -309,6 +311,40 @@ void
testIdleShutdownSplitFetcherWaitsUntilRecordProcessed() throws Exception {
}
}
+ @RepeatedTest(100)
+ void testAddSplitsWhileClosing() throws Exception {
Review Comment:
No, without the fix a single attempt fails about one time in three (3341 of
10000 locally). The window sits between `isEmpty()` and `next()` inside
`ConcurrentHashMap`, so there is no hook to force it. All 100 repetitions take
about 80 ms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
