MartijnVisser commented on code in PR #29386:
URL: https://github.com/apache/flink/pull/29386#discussion_r4192260687
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java:
##########
@@ -309,6 +311,40 @@ void
testIdleShutdownSplitFetcherWaitsUntilRecordProcessed() throws Exception {
}
}
+ @RepeatedTest(100)
+ void testAddSplitsWhileClosing() throws Exception {
Review Comment:
You're right, overriding `values()` makes it deterministic. I've replaced
the repeated test with yours and added you as co-author. It fails on master and
passes with the fix on JDK 17 and 21.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
