Savonitar commented on code in PR #332:
URL:
https://github.com/apache/flink-connector-kafka/pull/332#discussion_r4193950418
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/ExactlyOnceKafkaWriter.java:
##########
@@ -273,7 +273,8 @@ public void close() throws Exception {
this::abortCurrentProducer,
() -> closeAll(producerPool),
backchannel,
- super::close);
+ super::close,
+ adminClient);
Review Comment:
`IOUtils.closeAll` already skips null entries, that's why explicit check
isn't needed here.
We have a test that also covers closing the writer when the lazy admin
client was never created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
