Savonitar commented on code in PR #332:
URL:
https://github.com/apache/flink-connector-kafka/pull/332#discussion_r4218816217
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/ExactlyOnceKafkaWriterITCase.java:
##########
@@ -374,6 +379,57 @@ void testAbortOnClose() throws Exception {
}
}
+ /**
+ * Tests that POOLING releases its admin client and INCREMENTING closes
without creating one.
+ */
+ @ParameterizedTest
+ @EnumSource(TransactionNamingStrategy.class)
+ void testCloseReleasesAdminClient(TransactionNamingStrategy
namingStrategy) throws Exception {
Review Comment:
We discussed offline, but actually I found a test that uses EXCLUDE approach
https://github.com/apache/flink-connector-kafka/blob/main/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterITCase.java#L174
which also fits this test and allows to simplify + support coverage for future
strategies.
Addressed in a separate commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
