davidradl commented on code in PR #54:
URL:
https://github.com/apache/flink-connector-http/pull/54#discussion_r4197973768
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/clients/SinkHttpClientResponse.java:
##########
@@ -17,26 +17,83 @@
package org.apache.flink.connector.http.clients;
+import org.apache.flink.annotation.PublicEvolving;
import org.apache.flink.connector.http.sink.HttpSinkRequestEntry;
import org.apache.flink.connector.http.sink.httpclient.HttpRequest;
import lombok.Data;
import lombok.NonNull;
import lombok.ToString;
+import java.util.Collections;
import java.util.List;
+import java.util.stream.Collectors;
/**
* Data class holding {@link HttpSinkRequestEntry} instances that {@link
SinkHttpClient} attempted
- * to write, divided into two lists — successful and failed ones.
+ * to write, divided by the outcome of their HTTP response.
*/
@Data
+@PublicEvolving
@ToString
public class SinkHttpClientResponse {
/** A list of successfully written requests. */
- @NonNull private final List<HttpRequest> successfulRequests;
+ @NonNull private final List<HttpSinkRequestEntry> successfulRequests;
- /** A list of requests that {@link SinkHttpClient} failed to write. */
- @NonNull private final List<HttpRequest> failedRequests;
+ /** A list of requests that {@link SinkHttpClient} failed with a retryable
failure. */
+ @NonNull private final List<HttpSinkRequestEntry> failedRequests;
Review Comment:
maybe rename as retriableFailedRequests so it is more obvious
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
