bharathgunapati commented on PR #54: URL: https://github.com/apache/flink-connector-http/pull/54#issuecomment-6024227544
> I have not tested it locally - can you confirm you have done local testing with new and deprecated options I have done the Local testing through tests and examples covered both paths: New options http.sink.success-codes / retry-codes / ignored-response-codes retries (fixed + exponential), ignored status, fatal status, max-retries = 0 covered in connector tests (HttpSinkResponseClassifierTest, HttpDynamicTableSinkFactoryTest, etc.) and in downstream DataStream/Table ITs Deprecated / legacy options http.sink.error.code (e.g. 5XX treated as fatal) http.sink.error.code.exclude (e.g. 404 ignored) mixed legacy + new options rejected at creation covered in connector exclusivity tests and in flink-http-sink-examples ITs (supportsLegacyErrorCodeOptions, supportsLegacyExcludeAsIgnoredStatus, rejectsMixedLegacyAndNewStatusCodeOptions, plus Table DDL equivalents) Results: connector module: 649 tests passed examples against this branch: https://github.com/bharathgunapati/flink-http-sink-examples (CI green: [github.com/bharathgunapati/flink-htt…es/actions/runs/37519987357](https://github.com/bharathgunapati/flink-http-sink-examples/actions/runs/37519987357)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
