gustavodemorais commented on PR #29335: URL: https://github.com/apache/flink/pull/29335#issuecomment-6036096716
I think we might not need the `ValidationException` here. Tried removing it and just letting the output resolve to zero columns instead. Ad-hoc `SELECT` works fine (schema resolves to `[]`). If someone then tries `INSERT INTO` a real sink, Flink's own arity check already catches it with a clear message: ``` ValidationException: Column types of query result and sink for '...' do not match. Cause: Different number of columns. ``` So the dedicated validation feels redundant, and dropping it keeps ad-hoc `SELECT` usable. Wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
