MartijnVisser commented on PR #28953:
URL: https://github.com/apache/flink/pull/28953#issuecomment-6045850780

   @weiqingy @RocMarshal Looks like this PR has effectively broken master
   
   ```
   Oct 07 19:44:19 19:44:19.932 [ERROR] Failures: 
   Oct 07 19:44:19 19:44:19.932 [ERROR]   
EarlyFireJoinHintTest.testEarlyFireProcTimeOnRowTimeJoin:205->verify:282 
Expected: 
   Oct 07 19:44:19 Calc(select=[a, b])
   Oct 07 19:44:19 +- IntervalJoin(joinType=[LeftOuterJoin], 
windowBounds=[isRowTime=true, leftLowerBound=-10000, leftUpperBound=3600000, 
leftTimeIndex=1, rightTimeIndex=2], where=[((a = a0) AND (rowtime >= (rowtime0 
- 10000:INTERVAL SECOND)) AND (rowtime <= (rowtime0 + 3600000:INTERVAL 
HOUR)))], select=[a, rowtime, a0, b, rowtime0], earlyFireDelay=[5000], 
earlyFireTimeMode=[PROCTIME])
   Oct 07 19:44:19    :- Exchange(distribution=[hash[a]])
   Oct 07 19:44:19    :  +- WatermarkAssigner(rowtime=[rowtime], 
watermark=[rowtime])
   Oct 07 19:44:19    :     +- TableSourceScan(table=[[default_catalog, 
default_database, MyTable, project=[a, rowtime], metadata=[]]], fields=[a, 
rowtime])
   Oct 07 19:44:19    +- Exchange(distribution=[hash[a]])
   Oct 07 19:44:19       +- WatermarkAssigner(rowtime=[rowtime], 
watermark=[rowtime])
   Oct 07 19:44:19          +- TableSourceScan(table=[[default_catalog, 
default_database, MyTable2, project=[a, b, rowtime], metadata=[]]], fields=[a, 
b, rowtime])
   Oct 07 19:44:19  but was: 
   Oct 07 19:44:19 Calc(select=[a, b])
   Oct 07 19:44:19 +- IntervalJoin(joinType=[LeftOuterJoin], 
windowBounds=[isRowTime=true, leftLowerBound=-10000, leftUpperBound=3600000, 
leftTimeIndex=1, rightTimeIndex=2], where=[((a = a0) AND (rowtime >= (rowtime0 
- 10000:INTERVAL SECOND)) AND (rowtime <= (rowtime0 + 3600000:INTERVAL 
HOUR)))], select=[a, rowtime, a0, b, rowtime0], earlyFireDelay=[5000], 
earlyFireTimeMode=[PROCTIME])
   Oct 07 19:44:19    :- Exchange(distribution=[hash[a]])
   Oct 07 19:44:19    :  +- WatermarkAssigner(rowtime=[rowtime], 
watermark=[rowtime])
   Oct 07 19:44:19    :     +- TableSourceScan(table=[[default_catalog, 
default_database, MyTable, project=[a, rowtime]]], fields=[a, rowtime])
   Oct 07 19:44:19    +- Exchange(distribution=[hash[a]])
   Oct 07 19:44:19       +- WatermarkAssigner(rowtime=[rowtime], 
watermark=[rowtime])
   Oct 07 19:44:19          +- TableSourceScan(table=[[default_catalog, 
default_database, MyTable2, project=[a, b, rowtime]]], fields=[a, b, rowtime])
   Oct 07 19:44:19 
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to