weiqingy commented on PR #28953: URL: https://github.com/apache/flink/pull/28953#issuecomment-6051826883
You're right, sorry about that. Reproduced on clean master, and it's our test. FLINK-38569 stopped rendering `metadata=[]` in scan digests and updated every golden, including 28 lines of `EarlyFireJoinHintTest.xml`. This PR merged about three hours earlier and added a new case to that same file, so the sweep ran against a base where `testEarlyFireProcTimeOnRowTimeJoin` didn't exist yet and its two `TableSourceScan` lines kept the empty spec. Both were green on their own base. Fix is a 2-line golden update, the same edit the sweep made to the 8 sibling cases: #29428. `EarlyFireJoinHintTest` goes 17/18 to 18/18 locally, and `IntervalJoinTest` plus `IntervalJoinRestoreTest` are green too. Could one of you merge it when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
