CodeTrainerMan commented on code in PR #29304:
URL: https://github.com/apache/flink/pull/29304#discussion_r4212016650
##########
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/AbstractNonHaServices.java:
##########
@@ -58,7 +59,15 @@ public abstract class AbstractNonHaServices implements
HighAvailabilityServices
private boolean shutdown;
public AbstractNonHaServices() {
- this.jobResultStore = new EmbeddedJobResultStore();
+ this(new EmbeddedJobResultStore());
Review Comment:
You are right, `EmbeddedHaServices` was still going through the no-arg
`AbstractNonHaServices()` constructor, so the setting never reached the store
used by the MiniCluster and when high availability is turned off. I added an
overload that takes the `Configuration` and wired it up in both places:
`HighAvailabilityServicesUtils#createAvailableOrEmbeddedServices` (case `NONE`)
and the `SingletonHighAvailabilityServicesFactory` in `MiniCluster`, where the
configuration is already at hand. `EmbeddedHaServicesJobResultStoreTest` covers
it - without the option the clean entry is retained, with the option it is
evicted after the TTL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
