CodeTrainerMan commented on PR #29304: URL: https://github.com/apache/flink/pull/29304#issuecomment-6046909153
Thanks for the review, @dalelane - all three comments are addressed in `5e5f47c4`, and the branch is rebased onto the current `master` (it was 86 commits behind). * non-positive TTL is rejected (comment 3) * the configuration now reaches `EmbeddedHaServices`, so the option also applies to the `MiniCluster` and to the non-HA case (comment 2) * the eviction semantics are spelled out in the option description and the generated docs table (comment 1) Local verification: 66 tests in the high-availability area (incl. the new `EmbeddedHaServicesJobResultStoreTest`) and `MiniClusterITCase` (18 tests) pass, checkstyle reports 0 violations and `spotless:check` is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
