SEPURI-SAI-KRISHNA commented on code in PR #29410:
URL: https://github.com/apache/flink/pull/29410#discussion_r4217548722
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecOverAggregate.java:
##########
@@ -407,6 +407,12 @@ private KeyedProcessFunction<RowData, RowData, RowData>
createUnboundedOverProce
new EqualiserCodeGenerator(sortKeyRowType,
ctx.classLoader())
.generateRecordEqualiser("FirstMatchingSortKeyEqualiser");
+ // RowData#equals throws on a RAW accumulator field and never
matches a
+ // BinaryRowData read back from state, so the comparison has
to be generated.
+ final GeneratedRecordEqualiser generatedAccEqualiser =
Review Comment:
Agreed, 29412 is stacked on this branch. I checked the split holds: with the
copy but without the 40737 change, only the six data view tests fail, and those
fail on both backends. So this PR fixes ARRAY_AGG, LAG and the BITMAP
aggregates on heap, and 40737 fixes COLLECT, PERCENTILE and the distinct
aggregates on both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
