SEPURI-SAI-KRISHNA commented on code in PR #29410:
URL: https://github.com/apache/flink/pull/29410#discussion_r4217555028
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/over/NonTimeRowsUnboundedPrecedingFunction.java:
##########
@@ -99,6 +100,7 @@ public NonTimeRowsUnboundedPrecedingFunction(
genAggsHandler,
genRecordEqualiser,
genSortKeyEqualiser,
+ genAccEqualiser,
Review Comment:
Agreed, it cannot land in either order as it stands. Happy to rebase on
40883 once it is in and move its comparisons to accEqualiser, or to do that
here if this lands second. Whichever you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
