SEPURI-SAI-KRISHNA commented on code in PR #29412:
URL: https://github.com/apache/flink/pull/29412#discussion_r4217628470
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecOverAggregate.java:
##########
@@ -321,7 +321,11 @@ private KeyedProcessFunction<RowData, RowData, RowData>
createUnboundedOverProce
JavaScalaConversionUtil.toScala(aggCalls),
new boolean[aggCalls.size()],
Review Comment:
Dropped all five. aggCallNeedRetractions is all false here, and FIRST_VALUE,
LAST_VALUE and LISTAGG return correct results on both backends. JSON_OBJECTAGG
and JSON_ARRAYAGG do not parse with OVER. Added ARRAY_AGG, LAG and the BITMAP
aggregates, which are wrong on heap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
