SEPURI-SAI-KRISHNA commented on code in PR #29412:
URL: https://github.com/apache/flink/pull/29412#discussion_r4217571721
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/over/AbstractNonTimeUnboundedPrecedingOver.java:
##########
@@ -231,6 +246,18 @@ public void open(OpenContext openContext) throws Exception
{
accMapState = getRuntimeContext().getMapState(accStateDescriptor);
+ // A data view is stored as a RAW field inside the accumulator. The
aggregate functions
+ // change such a view in place, and the heap state backend hands back
the very object it
+ // stores, so the accumulator has to be copied before it is
accumulated into. Accumulators
+ // without a RAW field are immutable from the operator's point of view
and need no copy.
+ if (Arrays.stream(accTypes)
Review Comment:
Dropped, the copy now lives in getAccFromState and putAccInState on 29410.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
