snuyanzin commented on code in PR #29436:
URL: https://github.com/apache/flink/pull/29436#discussion_r4227763919
##########
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskExecutionStateTest.java:
##########
@@ -70,23 +70,23 @@ public void testSerialization() {
TaskExecutionState javaSerCopy2 =
CommonTestUtils.createCopySerializable(original2);
// equalities
- assertEquals(original1, javaSerCopy1);
- assertEquals(javaSerCopy1, original1);
+ assertThat(javaSerCopy1).isEqualTo(original1);
+ assertThat(original1).isEqualTo(javaSerCopy1);
- assertEquals(original2, javaSerCopy2);
- assertEquals(javaSerCopy2, original2);
+ assertThat(javaSerCopy2).isEqualTo(original2);
+ assertThat(original2).isEqualTo(javaSerCopy2);
// hash codes
- assertEquals(original1.hashCode(), javaSerCopy1.hashCode());
- assertEquals(original2.hashCode(), javaSerCopy2.hashCode());
+
assertThat(javaSerCopy1.hashCode()).isEqualTo(original1.hashCode());
+
assertThat(javaSerCopy2.hashCode()).isEqualTo(original2.hashCode());
Review Comment:
```suggestion
assertThat(javaSerCopy1).hasSameHashCodeAs(original1);
assertThat(javaSerCopy2).hasSameHashCodeAs(original2);
```
##########
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskExecutionStateTest.java:
##########
@@ -70,23 +70,23 @@ public void testSerialization() {
TaskExecutionState javaSerCopy2 =
CommonTestUtils.createCopySerializable(original2);
// equalities
- assertEquals(original1, javaSerCopy1);
- assertEquals(javaSerCopy1, original1);
+ assertThat(javaSerCopy1).isEqualTo(original1);
+ assertThat(original1).isEqualTo(javaSerCopy1);
- assertEquals(original2, javaSerCopy2);
- assertEquals(javaSerCopy2, original2);
+ assertThat(javaSerCopy2).isEqualTo(original2);
+ assertThat(original2).isEqualTo(javaSerCopy2);
// hash codes
- assertEquals(original1.hashCode(), javaSerCopy1.hashCode());
- assertEquals(original2.hashCode(), javaSerCopy2.hashCode());
+
assertThat(javaSerCopy1.hashCode()).isEqualTo(original1.hashCode());
+
assertThat(javaSerCopy2.hashCode()).isEqualTo(original2.hashCode());
Review Comment:
same for other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
