snuyanzin commented on code in PR #29436:
URL: https://github.com/apache/flink/pull/29436#discussion_r4227803857
##########
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java:
##########
@@ -811,12 +798,12 @@ public void testTriggerPartitionStateUpdate() throws
Exception {
partitionId,
checkResult ->
assertThat(
-
remoteChannelStateChecker.isProducerReadyOrAbortConsumption(
- checkResult),
- is(false)));
+ remoteChannelStateChecker
+
.isProducerReadyOrAbortConsumption(checkResult))
+ .isFalse());
promise.completeExceptionally(new
PartitionProducerDisposedException(partitionId));
- assertEquals(ExecutionState.CANCELING, task.getExecutionState());
+
assertThat(task.getExecutionState()).isEqualTo(ExecutionState.CANCELING);
Review Comment:
```suggestion
assertThat(task.getExecutionState()).isSameAs(ExecutionState.CANCELING);
```
##########
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java:
##########
@@ -841,13 +828,13 @@ public void testTriggerPartitionStateUpdate() throws
Exception {
partitionId,
checkResult ->
assertThat(
-
remoteChannelStateChecker.isProducerReadyOrAbortConsumption(
- checkResult),
- is(false)));
+ remoteChannelStateChecker
+
.isProducerReadyOrAbortConsumption(checkResult))
+ .isFalse());
promise.completeExceptionally(new RuntimeException("Any other
exception"));
- assertEquals(ExecutionState.FAILED, task.getExecutionState());
+
assertThat(task.getExecutionState()).isEqualTo(ExecutionState.FAILED);
Review Comment:
```suggestion
assertThat(task.getExecutionState()).isSameAs(ExecutionState.FAILED);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
