davidradl commented on code in PR #58:
URL:
https://github.com/apache/flink-connector-http/pull/58#discussion_r4232034109
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/preprocessor/OIDCAuthHeaderValuePreprocessor.java:
##########
@@ -31,7 +31,11 @@ public class OIDCAuthHeaderValuePreprocessor implements
HeaderValuePreprocessor
private final String oidcAuthURL;
private final String oidcTokenRequest;
- private Duration oidcExpiryReduction = Duration.ofSeconds(1);
+ private Duration oidcExpiryReduction =
+ OidcAccessTokenManager.DEFAULT_TOKEN_EXPIRATION_REDUCTION;
+
+ /** Created on first use so the cached token survives across requests but
is not serialized. */
Review Comment:
is the comment true that the cached token survives. It seemed to work before
when we did not cache the token manager. I think caching the token manager
makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
