davidradl commented on code in PR #58: URL: https://github.com/apache/flink-connector-http/pull/58#discussion_r4232085570
##########
docs/content/docs/connectors/table/http.md:
##########
@@ -266,7 +266,7 @@ Note the options with the prefix _http_ are the HTTP
connector specific options,
| http.security.cert.server.allowSelfSigned |
optional | Accept untrusted certificates for TLS communication.
|
| http.security.oidc.token.request |
optional | OIDC `Token Request` body in `application/x-www-form-urlencoded`
encoding
|
| http.security.oidc.token.endpoint.url |
optional | OIDC `Token Endpoint` url, to which the token request will be issued
|
-| http.security.oidc.token.expiry.reduction |
optional | OIDC tokens will be requested if the current time is later than the
cached token expiry time minus this value.
|
+| http.security.oidc.token.expiry.reduction |
optional | OIDC tokens will be requested if the current time is later than the
cached token expiry time minus this value. The default is `30s`.
|
Review Comment:
am I right in saying the documented and coded default was 1 second - we are
changing it to 30 seconds. Looks like we need to be consistent with existing
docs and use 1 second not 30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
