leonardBang commented on code in PR #4565: URL: https://github.com/apache/flink-cdc/pull/4565#discussion_r4246354051
########## NOTICE: ########## @@ -4,6 +4,149 @@ Copyright 2024-2026 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). +This project bundles the following dependencies under the MIT license. +See bundled license files for details. + +- AnchorJS v3.1.0 (https://github.com/bryanbraun/anchorjs) Copyright (c) 2016 Bryan Braun + -> in "docs/static/js/anchor.min.js" +- font-awesome:4.6.3 (css) (https://fontawesome.com/) - Created by Dave Gandy + -> css in "docs/static/font-awesome/css" +- chroma (css generated by Hugo) (https://github.com/alecthomas/chroma) Copyright (C) 2017 Alec Thomas + -> in "docs/assets/github.css" +- Hugo Book theme (https://github.com/alex-shpak/hugo-book) Copyright (c) 2018 Alex Shpak + -> in "docs/themes/book" + +The Flink CDC binary distributions bundle the following dependencies under the MIT license. Review Comment: Would it make sense to update the `META-INF/NOTICE` files of the independently released JARs as well? The root `NOTICE` is currently copied only into the binary tar by the `flink-cdc-dist` assembly, while Pipeline Connector, fat SQL Connector, and model JARs carry their own `META-INF/NOTICE` files. For example, the packaged Fluss connector JAR still contains only the ASF boilerplate, so the Orekit and Jackson attributions added here would not be distributed with that standalone JAR. Could we update the artifact-specific NOTICE files, or generate them during the build and add a packaging check against the final JAR contents? ########## NOTICE: ########## @@ -4,6 +4,149 @@ Copyright 2024-2026 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). +This project bundles the following dependencies under the MIT license. +See bundled license files for details. Review Comment: Could we verify that the referenced bundled license files are actually included in the source distribution? This section says, `See bundled license files for details`, but apart from `docs/themes/book/LICENSE`, I could not find license files for AnchorJS, Font Awesome, or Chroma in the source tree, and the root `LICENSE` contains only the Apache License 2.0 text. Would it make sense to include the relevant third-party license files (or aggregate them in a dedicated LICENSE file) and add a packaging check for the source archive? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
