leonardBang commented on code in PR #4565: URL: https://github.com/apache/flink-cdc/pull/4565#discussion_r4255349848
########## NOTICE: ########## @@ -4,6 +4,149 @@ Copyright 2024-2026 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). +This project bundles the following dependencies under the MIT license. +See bundled license files for details. Review Comment: Thanks for the update! I verified the source packaging flow: the three license files are now included in the generated source archive, the new packaging check passes, and removing the Hugo Book entry matches the fact that the submodule content is not packaged. One remaining question: would it make sense to reference these third-party license files from the top-level `LICENSE` as well? ASF licensing guidance generally places the licensing terms or pointers for bundled permissively licensed dependencies in `LICENSE`, while `NOTICE` is used for legally required attribution. Currently, the root `LICENSE` still contains only the Apache License 2.0 text, and the pointers to `licenses/LICENSE.anchorjs`, `licenses/LICENSE.font-awesome`, and `licenses/LICENSE.chroma` exist only in `NOTICE`. Could we add a short section to the root `LICENSE` mapping these bundled assets to their corresponding license files? The `NOTICE` entries can remain where attribution is required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
