[
https://issues.apache.org/jira/browse/FLINK-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853987#comment-15853987
]
ASF GitHub Bot commented on FLINK-4449:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2791#discussion_r99582640
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerRunner.java
---
@@ -55,6 +55,7 @@ public ResourceManagerRunner(
final ResourceManagerConfiguration resourceManagerConfiguration
= ResourceManagerConfiguration.fromConfiguration(configuration);
final SlotManagerFactory slotManagerFactory = new
DefaultSlotManager.Factory();
final JobLeaderIdService jobLeaderIdService = new
JobLeaderIdService(highAvailabilityServices);
+ final HeartbeatService heartbeatService = new
HeartbeatService(resourceManagerConfiguration, rpcService.getExecutor());
--- End diff --
Things which are started outside of the `ResourceManager` should also be
closed outside of it.
> Heartbeat Manager integration with TaskExecutor
> -----------------------------------------------
>
> Key: FLINK-4449
> URL: https://issues.apache.org/jira/browse/FLINK-4449
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: zhangjing
> Assignee: zhangjing
>
> ResourceManager need a heartbeat manager to monitor the connections with all
> registered TaskExecutor.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
