[
https://issues.apache.org/jira/browse/FLINK-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853986#comment-15853986
]
ASF GitHub Bot commented on FLINK-4449:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2791#discussion_r99582381
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -831,5 +856,30 @@ public void handleError(Throwable error) {
onFatalErrorAsync(error);
}
}
+
+ private class HeartbeatListenerWithTaskExecutor implements
HeartbeatListener<Void, Void> {
+
+ @Override
+ public void notifyHeartbeatTimeout(final ResourceID resourceID)
{
+ log.warn("Lost heartbeat with taskExecutor {}, mark the
taskExecutor as failed ", resourceID);
+ runAsync(new Runnable() {
+ @Override
+ public void run() {
+
heartbeatService.unmonitorTaskExecutor(resourceID);
--- End diff --
Why not removing the heartbeat target as part of the `notifyWorkerFailed`
call?
> Heartbeat Manager integration with TaskExecutor
> -----------------------------------------------
>
> Key: FLINK-4449
> URL: https://issues.apache.org/jira/browse/FLINK-4449
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: zhangjing
> Assignee: zhangjing
>
> ResourceManager need a heartbeat manager to monitor the connections with all
> registered TaskExecutor.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
