riyarawat-amazon commented on code in PR #258:
URL:
https://github.com/apache/flink-connector-aws/pull/258#discussion_r4326941209
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/enumerator/DynamoDbStreamsSourceEnumerator.java:
##########
@@ -93,7 +94,10 @@ public DynamoDbStreamsSourceEnumerator(
this.shardAssignerContext = new ShardAssignerContext(splitAssignment,
context);
InitialPosition initialPosition =
sourceConfig.get(STREAM_INITIAL_POSITION);
if (state == null) {
- this.startTimestamp = Instant.now();
+ this.startTimestamp =
+ initialPosition == InitialPosition.AT_TIMESTAMP
+ ?
DynamodbStreamsSourceConfigUtil.parseInitialTimestamp(sourceConfig)
Review Comment:
Done. The source now resolves the Instant once and passes it to the
enumerator, which no longer re-parses it. Added a test for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
