riyarawat-amazon commented on code in PR #258:
URL:
https://github.com/apache/flink-connector-aws/pull/258#discussion_r4326973709
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/enumerator/tracker/SplitTracker.java:
##########
@@ -179,13 +196,68 @@ private void addSplitToMapping(DynamoDbStreamsShardSplit
split) {
.add(split.splitId());
}
+ /**
+ * Adds shards discovered under the AT_TIMESTAMP initial position. Each
newly discovered shard
+ * (one that is not already tracked and is not an ancestor of an
already-tracked shard) is added
+ * at AT_TIMESTAMP: the service resolves the correct per-record position
via
+ * GetShardIterator(AT_TIMESTAMP), so a shard that straddles the timestamp
never emits
+ * pre-timestamp records and the position is independent of the discovery
path or restore
+ * timing. Ancestors of already-tracked shards are skipped because they
have already been
Review Comment:
Fixed the Javadoc, added a WARN when an untracked ancestor is skipped,
removed the duplicate comment, and dropped the extra checks to match the LATEST
path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
