rionmonster commented on code in PR #29565:
URL: https://github.com/apache/flink/pull/29565#discussion_r4351848569
##########
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/snapshot/LateralSnapshotJoinOperatorTest.java:
##########
@@ -1250,6 +1251,8 @@ void joinRespectsNullKeysFilter(boolean leftOuter,
boolean filterNullKey) throws
newHarness(op)) {
h.open();
addBuildChange(h, insertRecord(null, "v_null", 1L));
+ // A build row that can never match is not stored
+ assertThat(bufferedChangesForKey(h, op,
null)).hasSize(filterNullKey ? 0 : 1);
Review Comment:
Thanks for the review, much appreciated! Good catch here, I've gone ahead
and updated this and verified that the guard handles it as expected! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
