gustavodemorais commented on code in PR #29565:
URL: https://github.com/apache/flink/pull/29565#discussion_r4359617779
##########
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/snapshot/LateralSnapshotJoinOperatorTest.java:
##########
@@ -1250,6 +1251,8 @@ void joinRespectsNullKeysFilter(boolean leftOuter,
boolean filterNullKey) throws
newHarness(op)) {
h.open();
addBuildChange(h, insertRecord(null, "v_null", 1L));
+ // A build row that can never match is not stored
+ assertThat(bufferedChangesForKey(h, op,
null)).hasSize(filterNullKey ? 0 : 1);
Review Comment:
Thanks @rionmonster! I don't see the changes on the PR yet - the head is
still e09288c. Could you push them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
