wenjin272 commented on code in PR #1320:
URL: https://github.com/apache/flink-agents/pull/1320#discussion_r4356869192
##########
api/src/main/java/org/apache/flink/agents/api/subagent/SubagentFuture.java:
##########
@@ -44,8 +44,15 @@ public String getCallId() {
public abstract boolean isDone();
/**
- * Resolves the invocation, waiting until it reaches a terminal state.
Failures converge into a
- * failed {@link SubagentResult} rather than a separately reported
exceptional completion.
+ * Resolves the invocation, waiting until it reaches a terminal state. A
comprehensible
+ * sub-agent failure is returned as a failed {@link SubagentResult};
system-level exceptions,
+ * cancellation and interruption propagate to the caller.
+ *
+ * <p>Do not retry an await that throws. Any retry belongs inside its
await implementation.
+ * Successful repeated awaits may return the cached result. The built-in
deferred and async
Review Comment:
Agreed. Framework-side faults in internal calls should fail the action and
trigger recovery, so simply untracking the handle in finally would not be the
right fix. The issue is that ToolCallAction absorbs the original exception, and
finalization then fails with an unresolved-handle error. I suggest tracking
this as a follow-up to preserve direct propagation of framework faults, while
keeping this PR focused on deferred and async handles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
