wenjin272 commented on code in PR #1320:
URL: https://github.com/apache/flink-agents/pull/1320#discussion_r4356867955
##########
api/src/main/java/org/apache/flink/agents/api/subagent/SubagentFuture.java:
##########
@@ -44,8 +44,15 @@ public String getCallId() {
public abstract boolean isDone();
/**
- * Resolves the invocation, waiting until it reaches a terminal state.
Failures converge into a
- * failed {@link SubagentResult} rather than a separately reported
exceptional completion.
+ * Resolves the invocation, waiting until it reaches a terminal state. A
comprehensible
Review Comment:
Thanks for raising this. This PR focuses on individual awaits in
ToolCallAction, so I suggest leaving the group path unchanged for now and
discussing the cleanup semantics after a caller catches an awaitAll() exception
separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
