LuanaMihailescu commented on code in PR #4568:
URL: https://github.com/apache/flink-cdc/pull/4568#discussion_r4359228329
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mongodb-cdc/src/main/java/org/apache/flink/cdc/connectors/mongodb/internal/MongoDBEnvelope.java:
##########
@@ -148,7 +148,8 @@ public class MongoDBEnvelope {
public static String encodeValue(String value) {
Review Comment:
Thanks for the suggestion.
[MongoCredential](https://www.javadoc.io/static/org.mongodb/mongo-java-driver/3.12.14/com/mongodb/MongoCredential.html#createPlainCredential(java.lang.String,java.lang.String,char%5B%5D))
would allow us to pass credentials directly when creating the client in the
new source. However, the legacy source also uses this connection-string builder
and passes the URI to the MongoDB Kafka connector, so it would still require
URI encoding. Would keeping `encodeValue()` unchanged and applying the
space-encoding correction specifically to credentials in
`buildConnectionString()` be acceptable for this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
