LuanaMihailescu commented on code in PR #4568:
URL: https://github.com/apache/flink-cdc/pull/4568#discussion_r4379382117
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mongodb-cdc/src/main/java/org/apache/flink/cdc/connectors/mongodb/internal/MongoDBEnvelope.java:
##########
@@ -148,7 +148,8 @@ public class MongoDBEnvelope {
public static String encodeValue(String value) {
Review Comment:
Done in
[5fcd45b](https://github.com/apache/flink-cdc/pull/4568/changes/5fcd45b5ca2632d413ba1f2388b9701ef2787e7a)
— reverted `encodeValue()` to its original, generic implementation so it's
unaffected and safe for other callers. Moved the space-encoding correction into
a new private `encodeCredential()` helper in `MongoUtils`, applied only to
`username`/`password` when building the connection string in
`buildConnectionString()`. Also replaced `MongoDBEnvelopeTest` (which tested
the reverted behavior) with `MongoUtilsTest`, covering `buildConnectionString`
directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
