Admaing opened a new pull request, #1229:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1229
## What is the purpose of the change
Three operator config keys are a strict prefix of another key, which makes
converting a flat config map to yaml fail with `ClassCastException: String
cannot be cast to Map` as soon as both sides of a pair are configured. This
removes all three overlaps.
## Brief change log
-
`job.autoscaler.scaling.parallelism-alignment.mode.<name>.{class,<parameter>}`
renamed to
`job.autoscaler.scaling.parallelism-alignment.modes.<name>.{class,<parameter>}`.
The leaf `...parallelism-alignment.mode` key is unchanged; the old template
prefix is still read as a fallback and logs a deprecation warning
- `kubernetes.operator.savepoint.history.max.{age,count}.threshold`
renamed to `kubernetes.operator.savepoint.history.threshold.max.{age,count}`,
with `withDeprecatedKeys()` so existing configurations keep working
- Config reference docs regenerated, and the user docs now use the `modes`
prefix
- A reflection test now fails when any documented `ConfigOption` key is a
strict prefix of another
## Verifying this change
This change added tests and can be verified as follows:
- `ConfigOptionKeyPrefixTest` reflects over every `ConfigOption` in the
documented locations and fails when one key is a strict prefix of another.
`testAllConfigKeysConvertToYamlAndBack` sets all keys and round-trips them
through `YamlParserUtils`. On the code without the rename it fails with
`ClassCastException: class java.lang.String cannot be cast to class
java.util.Map`, which reproduces the reported bug
- `KubernetesOperatorConfigOptionsTest` checks the renamed threshold keys
and that the deprecated keys are still read
- `AlignmentModeTest` covers a custom mode configured under the deprecated
template prefix and the precedence of the new prefix
- `mvn -pl
flink-autoscaler,flink-kubernetes-operator,flink-kubernetes-docs -am verify`
passes
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (DeepSeek Harness)
Generated-by: DeepSeek Harness (deepseek-v4.1-flash)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
