Admaing commented on PR #1229:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1229#issuecomment-6398998186
Thanks for the review. All points are addressed in 3ee891f7 (force-pushed,
single commit):
- **Naming**: the per-name templates are back to
`...parallelism-alignment.mode.<name>.{class,<parameter>}`. What I renamed
instead is the top/parent property:
`job.autoscaler.scaling.parallelism-alignment.mode` ->
`job.autoscaler.scaling.parallelism-alignment.modes`, with the old key kept via
`withDeprecatedKeys()` (both the `job.autoscaler.` and the legacy
`kubernetes.operator.job.autoscaler.` form).
- **plugins.md**: the added paragraphs are deleted, in both the English and
the `content.zh` page. Only the selector-key mentions were updated to
`...modes`, the `<name>` templates are untouched.
- **Javadoc**: the verbose Javadoc and the `DEPRECATED_..._PREFIX` constants
are gone; deprecation is expressed only through `withDeprecatedKeys()`, so
nothing extra shows up in the generated docs.
- **Logging**: removed the logger, the `AtomicBoolean` guard and
`warnIfDeprecatedAlignmentModePrefixIsUsed` from `AutoScalerOptions`. The class
is back to plain properties plus the existing key helpers.
- **Unnecessary logic**: removed the deprecated prefix helpers
(`deprecatedCustomAlignmentModeClassKey/FallbackKey`), the extra
`withFallbackKeys` entries and the varargs change to
`prefixStrippedConfiguration`, so that method is back to its original shape.
Kept from the first version: the
`savepoint.history.max.{age,count}.threshold` renames (with
`withDeprecatedKeys()`), and the two guard tests (`ConfigOptionKeyPrefixTest`)
that fail when any documented key is a strict prefix of another and round-trip
all keys through the yaml parser.
Verification:
- `flink-autoscaler`: 302 tests, all green.
- `flink-kubernetes-docs`: `ConfigOptionKeyPrefixTest` green (no key is a
strict prefix of another any more, and all keys round-trip through
`YamlParserUtils`).
- `flink-kubernetes-operator`: 2269 tests, one failure in
`ArtifactManagerTest#testHttpFetchTimesOutOnConnectToUnreachableHost` ("Read
timed out" instead of "connect timed out"). It fails the same way on unmodified
`main` in this environment, so it is unrelated to this change.
- Generated config reference regenerated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
