sheinbergon commented on code in PR #29547:
URL: https://github.com/apache/flink/pull/29547#discussion_r4370060401
##########
flink-core/src/main/java/org/apache/flink/util/concurrent/ExecutorThreadFactory.java:
##########
@@ -97,11 +97,7 @@ public ExecutorThreadFactory(String poolName,
UncaughtExceptionHandler exception
this.threadPriority = threadPriority;
this.exceptionHandler = exceptionHandler;
- SecurityManager securityManager = System.getSecurityManager();
- this.group =
- (securityManager != null)
- ? securityManager.getThreadGroup()
- : Thread.currentThread().getThreadGroup();
+ this.group = Thread.currentThread().getThreadGroup();
Review Comment:
I'll need to check if retaining `SecurityManager securityManager =
System.getSecurityManager();` raises an exception on JDK 24 and onwards. If it
does, would you rather we keep this approach or add exception handling logic
and fallbacks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
