bharathgunapati commented on code in PR #58:
URL:
https://github.com/apache/flink-connector-http/pull/58#discussion_r4371904429
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/config/HttpConnectorConfigConstants.java:
##########
@@ -132,6 +132,16 @@ public final class HttpConnectorConfigConstants {
public static final String SINK_HTTP_TIMEOUT_SECONDS =
FLINK_CONNECTOR_HTTP_SINK + "request.timeout";
+ public static final String SINK_QUERY_HTTP_VERSION =
FLINK_CONNECTOR_HTTP_SINK + "http-version";
Review Comment:
Agreed. I renamed it to `SINK_HTTP_VERSION`. The lookup side still has
`SOURCE_LOOKUP_QUERY_HTTP_VERSION`. I left that one alone to keep this PR
focused on the sink, but I can rename it in a follow-up if you want both to
match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
