bharathgunapati commented on PR #58: URL: https://github.com/apache/flink-connector-http/pull/58#issuecomment-6401576237
@davidradl Thanks for the review. All three comments are addressed in the latest push, see the threads above. One more change that is not from the review: the token request had no timeout, and its HTTP client had no connect timeout. If the identity provider did not answer, the sink writer thread would wait forever. The token request now uses the connector's request timeout: `http.sink.request.timeout` for the sink and `http.source.lookup.request.timeout` for lookups. A timeout fails the request with a message that names the token endpoint. New tests in `RequestSubmitterOidcTest` and `OIDCAuthHeaderValuePreprocessorTest` cover this. I also added two lines to the Restrictions section: the token request does not use the proxy or TLS trust options, and it is bounded by the request timeout. Making the token request use the proxy and trust settings is a good follow-up for lookup and sink together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
