hanyuzheng7 commented on code in PR #29658:
URL: https://github.com/apache/flink/pull/29658#discussion_r4405424241
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java:
##########
@@ -607,14 +607,25 @@ private <T> void setKeyContextElement(StreamRecord<T>
record, KeySelector<T, ?>
throws Exception {
if (selector != null) {
Object key = selector.getKey(record.getValue());
- setCurrentKey(key);
+ moveToNextKey(key);
Review Comment:
This also changes STREAMING: the keyed input path no longer goes through
setCurrentKey, so operators outside Flink that override setCurrentKey (for
example to flush buffered records on a key change) would silently stop being
called. Is that intended? If so, maybe worth a release note. Same for
`AbstractStreamOperatorV2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
