pnowojski commented on PR #29658: URL: https://github.com/apache/flink/pull/29658#issuecomment-6496181154
Thanks for the reviews! I pushed the changes as `fixup!`/`amend!` commits on top of the reviewed ones, so they can be reviewed separately and squashed before merging: - @ykisana: fixed `StateBackendBenchmarkUtilsTest` to use `moveToNextKey`, as you suggested. - The keyed input path now calls `moveToNextKey` only for key-sorted inputs (BATCH with sorted inputs); otherwise it still calls `setCurrentKey`, so STREAMING behaves exactly as before, including for operators overriding `setCurrentKey`. - New commit: `KeyedSortPartitionOperator` no longer sets the current key. It sorts by key itself, so its input isn't sorted by key and it doesn't use keyed state, but it would now fail in BATCH because it switched keys for every record. Covered by a new `KeyedPartitionWindowedStreamITCase` test. @rionmonster you mentioned two nits, but I only see one inline. Could you check whether the other one got lost? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
