fresh-borzoni commented on PR #28090: URL: https://github.com/apache/flink/pull/28090#issuecomment-6468352225
@xuyangzhong @featzhang @gustavodemorais Rebased on current master; all review comments are addressed @gustavodemorais, your FLINK-40841 now handles the regular non-equi join at runtime, so I dropped this PR's UPDATE_BEFORE guard for `StreamPhysicalJoin`, in a separate commit. Only its DELETE_BY_KEY guard stays. What's left is still broken on master: filters on non-upsert-key columns pushed into the source, in lookup joins, or in multi-join conditions leave phantom rows. Also the corresponding `ChangelogSourceITCase` tests fail on master without this fix. Friendly ping for a review 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
