fresh-borzoni commented on code in PR #28090:
URL: https://github.com/apache/flink/pull/28090#discussion_r4417675924


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkChangelogModeInferenceProgram.scala:
##########
@@ -1422,27 +1473,34 @@ class FlinkChangelogModeInferenceProgram extends 
FlinkOptimizeProgram[StreamOpti
           createNewNode(process, Some(children), providedDeleteTrait)
 
         case join: StreamPhysicalJoin =>

Review Comment:
   Actually this guard isn't needed either: since FLINK-40858 the join operator 
looks up the stored row for key-only deletes. Dropped it, so plain joins are 
untouched now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to