MartijnVisser commented on code in PR #29660:
URL: https://github.com/apache/flink/pull/29660#discussion_r4410434774
##########
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java:
##########
@@ -314,15 +324,30 @@ public CompletableFuture<Void> shutdownServer() {
if (bootstrap != null) {
EventLoopGroup group = bootstrap.config().group();
if (group != null && !group.isShutdown()) {
- group.shutdownGracefully(0L, 0L, TimeUnit.MILLISECONDS)
+ // Close the channels before shutting down the event
loops. With a quiet period
+ // of 0, Netty 4.2 can terminate an event loop without
closing its channels,
+ // which leaks their sockets. TODO: Drop the explicit
close once
Review Comment:
I'd keep the explicit close after the Netty fix as well, it closes the
sockets regardless of how the event loop shuts down. So I think the TODO can go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
