MartijnVisser commented on code in PR #29644: URL: https://github.com/apache/flink/pull/29644#discussion_r4413006124
########## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/batch/RuntimeFilterBatchRestoreTest.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.plan.nodes.exec.batch; + +import org.apache.flink.table.planner.plan.nodes.exec.ExecNode; +import org.apache.flink.table.planner.plan.nodes.exec.batch.runtimefilter.BatchExecGlobalRuntimeFilterBuilder; +import org.apache.flink.table.planner.plan.nodes.exec.batch.runtimefilter.BatchExecLocalRuntimeFilterBuilder; +import org.apache.flink.table.planner.plan.nodes.exec.batch.runtimefilter.BatchExecRuntimeFilter; +import org.apache.flink.table.planner.plan.nodes.exec.testutils.BatchRestoreTestBase; +import org.apache.flink.table.test.program.TableTestProgram; + +import java.util.Arrays; +import java.util.Collections; +import java.util.List; + +/** Restore tests for {@link BatchExecRuntimeFilter}. */ +public class RuntimeFilterBatchRestoreTest extends BatchRestoreTestBase { + + public RuntimeFilterBatchRestoreTest() { + super( Review Comment: This test still passes with the `BatchExecGlobalRuntimeFilterBuilder.class` fix reverted, since it only loads the committed plan. Could you also make it check a freshly compiled plan? ########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/runtimefilter/BatchExecGlobalRuntimeFilterBuilder.java: ########## @@ -52,15 +65,28 @@ public BatchExecGlobalRuntimeFilterBuilder( int maxRowCount) { super( ExecNodeContext.newNodeId(), - ExecNodeContext.newContext(BatchExecLocalRuntimeFilterBuilder.class), + ExecNodeContext.newContext(BatchExecGlobalRuntimeFilterBuilder.class), Review Comment: No impact outside compiled plans: without `@ExecNodeMetadata`, both classes get an empty context and config. With this PR's annotations but not this fix, the global builder is serialized as the local one and fails to restore with an NPE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
