jnh5y commented on code in PR #29644:
URL: https://github.com/apache/flink/pull/29644#discussion_r4404092630
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/runtimefilter/BatchExecGlobalRuntimeFilterBuilder.java:
##########
@@ -52,15 +65,28 @@ public BatchExecGlobalRuntimeFilterBuilder(
int maxRowCount) {
super(
ExecNodeContext.newNodeId(),
-
ExecNodeContext.newContext(BatchExecLocalRuntimeFilterBuilder.class),
+
ExecNodeContext.newContext(BatchExecGlobalRuntimeFilterBuilder.class),
Review Comment:
Does the PR description and/or ticket mention it? It may be worth having a
separate ticket / commit for this bug fix.
Would it impact any users outside of folks needing a batch compiled plan?
If there's no impact, maybe the extra documentation/work is not worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
