[
https://issues.apache.org/jira/browse/FLINK-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857511#comment-15857511
]
ASF GitHub Bot commented on FLINK-5219:
---------------------------------------
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r99998638
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggregatePreProcessor.scala
---
@@ -19,30 +19,36 @@ package org.apache.flink.table.runtime.aggregate
import java.lang.Iterable
-import org.apache.flink.api.common.functions.RichGroupCombineFunction
+import org.apache.flink.api.common.functions.{AbstractRichFunction,
GroupCombineFunction,
+MapPartitionFunction}
import org.apache.flink.api.common.typeinfo.TypeInformation
import org.apache.flink.api.java.typeutils.ResultTypeQueryable
import org.apache.flink.types.Row
import org.apache.flink.configuration.Configuration
import org.apache.flink.util.{Collector, Preconditions}
/**
- * This wraps the aggregate logic inside of
- * [[org.apache.flink.api.java.operators.GroupCombineOperator]].
+ * It wraps the aggregate logic inside of
+ * [[org.apache.flink.api.java.operators.GroupCombineOperator]] and
+ * [[org.apache.flink.api.java.operators.MapPartitionOperator]] It is
used for
+ * Sessiontime-window on batch.
*
* @param aggregates The aggregate functions.
* @param groupingKeys The indexes of the grouping fields.
* @param intermediateRowArity The intermediate row field count.
* @param gap Session time window gap.
* @param intermediateRowType Intermediate row data type.
*/
-class DataSetSessionWindowAggregateCombineGroupFunction(
+class DataSetSessionWindowAggregatePreProcessor(
aggregates: Array[Aggregate[_ <: Any]],
groupingKeys: Array[Int],
intermediateRowArity: Int,
gap: Long,
@transient intermediateRowType: TypeInformation[Row])
- extends RichGroupCombineFunction[Row,Row] with ResultTypeQueryable[Row] {
+ extends AbstractRichFunction
+ with MapPartitionFunction[Row,Row]
--- End diff --
I would like to indent `with` and `extends` on the same indent.
> Add non-grouped session windows for batch tables
> ------------------------------------------------
>
> Key: FLINK-5219
> URL: https://issues.apache.org/jira/browse/FLINK-5219
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> Add non-grouped session windows for batch tables as described in
> [FLIP-11|https://cwiki.apache.org/confluence/display/FLINK/FLIP-11%3A+Table+API+Stream+Aggregations].
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
