[
https://issues.apache.org/jira/browse/FLINK-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857513#comment-15857513
]
ASF GitHub Bot commented on FLINK-5219:
---------------------------------------
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r99996840
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -291,13 +292,13 @@ object AggregateUtil {
inputType,
Option(Array(BasicTypeInfo.LONG_TYPE_INFO,
BasicTypeInfo.LONG_TYPE_INFO)))
- new DataSetSessionWindowAggregateCombineGroupFunction(
+ new DataSetSessionWindowAggregatePreProcessor(
aggregates,
groupings,
// the addition two fields are used to store window-start and
window-end attributes
intermediateRowArity + 2,
asLong(gap),
- combineReturnType)
+ combineReturnType).asInstanceOf[GroupCombineFunction[Row,Row]]
--- End diff --
Can we leave out the `asInstanceOf` ?
> Add non-grouped session windows for batch tables
> ------------------------------------------------
>
> Key: FLINK-5219
> URL: https://issues.apache.org/jira/browse/FLINK-5219
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> Add non-grouped session windows for batch tables as described in
> [FLIP-11|https://cwiki.apache.org/confluence/display/FLINK/FLIP-11%3A+Table+API+Stream+Aggregations].
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
