jennifer-xiong25 commented on PR #1245:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/1245#issuecomment-6590441824

   Picking this up again after #1072. The problem was that after an aborted 
blue/green transition, `status.lastReconciledSpec` names the spec that was 
attempted, so nothing in the status says which spec the active deployment is 
actually running. Consumers reading the status conclude the failed update 
succeeded.
   
   Fix here keeps lastReconciledSpec set before startTransition as requested on 
#1072 and does not touch it on abort, so the failed transition is not retried. 
Instead it adds status.lastStableSpec, set whenever a spec is applied 
(transition and suspend finalization, in-place patches), mirroring 
`ReconciliationStatus.lastStableSpec` on FlinkDeployment. After an abort, 
lastStableSpec is the running spec and lastReconciledSpec is the attempted one.
   
   @gyfora I can't edit the JIRA yet (no ASF account), so could you retitle 
[FLINK-40333](https://issues.apache.org/jira/browse/FLINK-40333) to something 
like "Expose the running spec on FlinkBlueGreenDeployment status after an 
aborted transition"?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to