jennifer-xiong25 opened a new pull request, #1245:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1245
## What is the purpose of the change
After an aborted Blue/Green transition, `lastReconciledSpec` names the spec
that was attempted, so nothing in the status says which spec the active
deployment is actually running. This adds `lastStableSpec` to
`FlinkBlueGreenDeploymentStatus`, mirroring
`ReconciliationStatus.lastStableSpec` on `FlinkDeployment`.
Follows up on #1072. As requested there, `lastReconciledSpec` is still set
before `startTransition`, and abort leaves it untouched so the failed
transition is not retried. The running spec is reported through the new field
instead.
## Brief change log
- `FlinkBlueGreenDeploymentStatus.lastStableSpec` and
`BlueGreenUtils.markReconciledSpecAsStable`
- Marked stable when a spec is applied: transition finalization, suspend
finalization, and the in-place patch paths (suspend, resume, patch while
suspended, child patch)
- CRD and status reference docs updated for the new field
## Verifying this change
This change added tests and can be verified as follows:
- Extended `verifyReadyTimestampResetOnAbortPreventsPrematureBlueDelete`
to assert that after an abort `lastStableSpec` still names Blue's running spec
while `lastReconciledSpec` keeps the attempted one
- `assertFinalized` now checks `lastStableSpec` equals
`lastReconciledSpec` after every finalized transition
- `FlinkBlueGreenDeploymentControllerTest`: 76 tests pass
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
yes, one additive status field
- Core observer or reconciler logic that is regularly executed: yes
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
