autophagy commented on code in PR #29130:
URL: https://github.com/apache/flink/pull/29130#discussion_r4453184066
##########
flink-table/flink-table-test-utils/src/main/java/org/apache/flink/table/runtime/functions/ProcessTableFunctionTestHarness.java:
##########
@@ -1737,9 +1790,7 @@ private List<ArgumentInfo>
extractAndValidateTypeInference(
Map<Integer, TableSemantics> tableSemanticsMap = new HashMap<>();
for (int i = 0; i < tableArgs.size(); i++) {
TableArgumentInfo tArg = tableArgs.get(i);
- int[] partitionIndices = getPartitionColumnIndices(tArg);
- tableSemanticsMap.put(
- i, new TestHarnessTableSemantics(tArg.dataType,
partitionIndices));
+ tableSemanticsMap.put(i,
TestHarnessTableSemantics.forTypeInference(tArg, -1));
Review Comment:
Yeah, it does 😬 i think it might be better here to actually derive the index
inside the factory (and then I can also update it so that state type inf and
getting the changelog mode actually see the real time column, which I missed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
