snuyanzin commented on code in PR #29697:
URL: https://github.com/apache/flink/pull/29697#discussion_r4473023903
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdUpsertKeys.scala:
##########
@@ -322,13 +322,14 @@ class FlinkRelMdUpsertKeys private extends
MetadataHandler[UpsertKeys] {
var leftFieldCount = inputs.get(0).getRowType.getFieldCount
var leftUpsertKeys = fmq.getUpsertKeys(inputs.get(0))
- val leftJoinKeyIndices =
ImmutableBitSet.of(multiJoin.getJoinKeyIndices(0): _*)
-
// Process each subsequent input as right side of join
for (i <- 1 until inputs.size) {
val rightInput = inputs.get(i)
val rightUpsertKeys = fmq.getUpsertKeys(rightInput)
val joinType = joinTypes.get(i)
+ // The columns this join equates on each side. On the left, only the
columns that input i's
+ // conditions reference count, not every join column of the inputs
before it.
Review Comment:
nit : can we reduce comment to something like
```suggestion
// Only the left columns that input i's own condition references, not
every previous join column.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
